sitegui/nodejs-websocket
1
0
Fork 0
Code Issues 15 Pull requests 3 Projects Releases Packages Wiki Activity Actions

Bump minimatch and mocha #65

Open
dependabot[bot] wants to merge 1 commit from dependabot/npm_and_yarn/minimatch-and-mocha-5.0.1 into master
pull from: dependabot/npm_and_yarn/minimatch-and-mocha-5.0.1
merge into: sitegui:master
Conversation 0 Commits 1 Files changed 2 +530 -77
dependabot[bot] commented 2023-04-15 13:35:02 +00:00 (Migrated from github.com)
Copy link

Bumps minimatch to 5.0.1 and updates ancestor dependency mocha. These dependencies need to be updated together.

Updates minimatch from 3.0.4 to 5.0.1

Changelog

Sourced from minimatch's changelog.

change log

9.0

  • No default export, only named exports.

8.0

  • Recursive descent parser for extglob, allowing correct support for arbitrarily nested extglob expressions
  • Bump required Node.js version

7.4

  • Add escape() method
  • Add unescape() method
  • Add Minimatch.hasMagic() method

7.3

  • Add support for posix character classes in a unicode-aware way.

7.2

  • Add windowsNoMagicRoot option

7.1

  • Add optimizationLevel configuration option, and revert the default back to the 6.2 style minimal optimizations, making the advanced transforms introduced in 7.0 opt-in. Also, process provided file paths in the same way in optimizationLevel:2 mode, so most things that matched with optimizationLevel 1 or 0 should match with level 2 as well. However, level 1 is the default, out of an abundance of caution.

7.0

  • Preprocess patterns to simplify complicated patterns and reduce out .. pattern portions where possible. Note that this means a pattern like a/b/../* will be equivalent to a/*, and will not match the string a/b/../c. If this causes problems, it can be addressed in a patch release by resolving .. portions in the test string.

6.2

  • Add nocaseMagicOnly flag

6.1

... (truncated)

Commits
  • 9f49616 5.0.1
  • cdc3188 don't load the whole path module just for the sep
  • dfa4f22 test unix path so win32 has full coverage
  • a000988 remove unused npmignore file
  • 0b2d3ba mention fnmatch(3) in impl comparison
  • 8c3f5f4 skip tests on windows that rely on \ being a valid path char
  • fc44f5f 5.0.0
  • 9104d8d Expect exclusively forward slash as path sep, same as node-glob
  • 58b72d3 fix(brace-expansion): ignore only blocks that begins with $
  • 048ada0 4.2.1
  • Additional commits viewable in compare view

Updates mocha from 5.2.0 to 10.2.0

Release notes

Sourced from mocha's releases.

v10.2.0

10.2.0 / 2022-12-11

🎉 Enhancements

  • #4945: API: add possibility to decorate ESM name before import (@​j0tunn)

🐛 Fixes

📖 Documentation

v10.1.0

10.1.0 / 2022-10-16

🎉 Enhancements

🔩 Other

v10.0.0

10.0.0 / 2022-05-01

💥 Breaking Changes

🔩 Other

... (truncated)

Changelog

Sourced from mocha's changelog.

10.2.0 / 2022-12-11

🎉 Enhancements

  • #4945: API: add possibility to decorate ESM name before import (@​j0tunn)

🐛 Fixes

📖 Documentation

10.1.0 / 2022-10-16

🎉 Enhancements

🔩 Other

10.0.0 / 2022-05-01

💥 Breaking Changes

🔩 Other

... (truncated)

Commits
Maintainer changes

This version was pushed to npm by juergba, a new releaser for mocha since your current version.


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.
Bumps [minimatch](https://github.com/isaacs/minimatch) to 5.0.1 and updates ancestor dependency [mocha](https://github.com/mochajs/mocha). These dependencies need to be updated together. Updates `minimatch` from 3.0.4 to 5.0.1 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/isaacs/minimatch/blob/main/changelog.md">minimatch's changelog</a>.</em></p> <blockquote> <h1>change log</h1> <h2>9.0</h2> <ul> <li>No default export, only named exports.</li> </ul> <h2>8.0</h2> <ul> <li>Recursive descent parser for extglob, allowing correct support for arbitrarily nested extglob expressions</li> <li>Bump required Node.js version</li> </ul> <h2>7.4</h2> <ul> <li>Add <code>escape()</code> method</li> <li>Add <code>unescape()</code> method</li> <li>Add <code>Minimatch.hasMagic()</code> method</li> </ul> <h2>7.3</h2> <ul> <li>Add support for posix character classes in a unicode-aware way.</li> </ul> <h2>7.2</h2> <ul> <li>Add <code>windowsNoMagicRoot</code> option</li> </ul> <h2>7.1</h2> <ul> <li>Add <code>optimizationLevel</code> configuration option, and revert the default back to the 6.2 style minimal optimizations, making the advanced transforms introduced in 7.0 opt-in. Also, process provided file paths in the same way in optimizationLevel:2 mode, so <em>most</em> things that matched with optimizationLevel 1 or 0 <em>should</em> match with level 2 as well. However, level 1 is the default, out of an abundance of caution.</li> </ul> <h2>7.0</h2> <ul> <li>Preprocess patterns to simplify complicated patterns and reduce out <code>..</code> pattern portions where possible. Note that this means a pattern like <code>a/b/../*</code> will be equivalent to <code>a/*</code>, and will <em>not</em> match the string <code>a/b/../c</code>. If this causes problems, it can be addressed in a patch release by resolving <code>..</code> portions in the test string.</li> </ul> <h2>6.2</h2> <ul> <li>Add nocaseMagicOnly flag</li> </ul> <h2>6.1</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/isaacs/minimatch/commit/9f49616b782481f3bc352ca76db958b813f14fe8"><code>9f49616</code></a> 5.0.1</li> <li><a href="https://github.com/isaacs/minimatch/commit/cdc3188d14187a6d38dc2ab4731497e62e55c24a"><code>cdc3188</code></a> don't load the whole path module just for the sep</li> <li><a href="https://github.com/isaacs/minimatch/commit/dfa4f221e26891bc18f78e49d4d8dc366f3082e5"><code>dfa4f22</code></a> test unix path so win32 has full coverage</li> <li><a href="https://github.com/isaacs/minimatch/commit/a0009885848ab6768610d62aefee48c3ae841bcc"><code>a000988</code></a> remove unused npmignore file</li> <li><a href="https://github.com/isaacs/minimatch/commit/0b2d3ba2b00522ecba29704a9713d443981b02df"><code>0b2d3ba</code></a> mention fnmatch(3) in impl comparison</li> <li><a href="https://github.com/isaacs/minimatch/commit/8c3f5f4028be881710d2439da4f87d0f61cd8074"><code>8c3f5f4</code></a> skip tests on windows that rely on \ being a valid path char</li> <li><a href="https://github.com/isaacs/minimatch/commit/fc44f5f9123f534ecbf76af65558eb87d90f1028"><code>fc44f5f</code></a> 5.0.0</li> <li><a href="https://github.com/isaacs/minimatch/commit/9104d8d175bdd8843338103be1401f80774d2a10"><code>9104d8d</code></a> Expect exclusively forward slash as path sep, same as node-glob</li> <li><a href="https://github.com/isaacs/minimatch/commit/58b72d34c69d7eda272ed0491b688b7dc8f8c005"><code>58b72d3</code></a> fix(brace-expansion): ignore only blocks that begins with $</li> <li><a href="https://github.com/isaacs/minimatch/commit/048ada0f1f2c84718477050a25f5fb457e7fc75e"><code>048ada0</code></a> 4.2.1</li> <li>Additional commits viewable in <a href="https://github.com/isaacs/minimatch/compare/v3.0.4...v5.0.1">compare view</a></li> </ul> </details> <br /> Updates `mocha` from 5.2.0 to 10.2.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/mochajs/mocha/releases">mocha's releases</a>.</em></p> <blockquote> <h2>v10.2.0</h2> <h1>10.2.0 / 2022-12-11</h1> <h2>:tada: Enhancements</h2> <ul> <li><a href="https://redirect.github.com/mochajs/mocha/issues/4945">#4945</a>: API: add possibility to decorate ESM name before import (<a href="https://github.com/j0tunn"><strong><code>@​j0tunn</code></strong></a>)</li> </ul> <h2>:bug: Fixes</h2> <ul> <li><a href="https://redirect.github.com/mochajs/mocha/issues/4946">#4946</a>: Browser: color of failed test icon (<a href="https://github.com/kleisauke"><strong><code>@​kleisauke</code></strong></a>)</li> </ul> <h2>:book: Documentation</h2> <ul> <li><a href="https://redirect.github.com/mochajs/mocha/issues/4944">#4944</a>: Remove duplicated header (<a href="https://github.com/PauloGoncalvesBH"><strong><code>@​PauloGoncalvesBH</code></strong></a>)</li> </ul> <h2>v10.1.0</h2> <h1>10.1.0 / 2022-10-16</h1> <h2>:tada: Enhancements</h2> <ul> <li><a href="https://redirect.github.com/mochajs/mocha/issues/4896">#4896</a>: Browser: add support for <code>prefers-color-scheme: dark</code> (<a href="https://github.com/greggman"><strong><code>@​greggman</code></strong></a>)</li> </ul> <h2>:nut_and_bolt: Other</h2> <ul> <li><a href="https://redirect.github.com/mochajs/mocha/issues/4912">#4912</a>: Browser: increase contrast for replay buttons (<a href="https://github.com/JoshuaKGoldberg"><strong><code>@​JoshuaKGoldberg</code></strong></a>)</li> <li><a href="https://redirect.github.com/mochajs/mocha/issues/4905">#4905</a>: Use standard <code>Promise.allSettled</code> instead of polyfill (<a href="https://github.com/outsideris"><strong><code>@​outsideris</code></strong></a>)</li> <li><a href="https://redirect.github.com/mochajs/mocha/issues/4899">#4899</a>: Upgrade official GitHub actions to latest (<a href="https://github.com/ddzz"><strong><code>@​ddzz</code></strong></a>)</li> <li><a href="https://redirect.github.com/mochajs/mocha/issues/4770">#4770</a>: Fix regex in function <code>clean</code>(<a href="https://github.com/yetingli"><strong><code>@​yetingli</code></strong></a>)</li> </ul> <h2>v10.0.0</h2> <h1>10.0.0 / 2022-05-01</h1> <h2>:boom: Breaking Changes</h2> <ul> <li> <p><a href="https://redirect.github.com/mochajs/mocha/issues/4845">#4845</a>: <strong>Drop Node.js v12.x support</strong> (<a href="https://github.com/juergba"><strong><code>@​juergba</code></strong></a>)</p> </li> <li> <p><a href="https://redirect.github.com/mochajs/mocha/issues/4848">#4848</a>: Drop Internet-Explorer-11 support (<a href="https://github.com/juergba"><strong><code>@​juergba</code></strong></a>)</p> </li> <li> <p><a href="https://redirect.github.com/mochajs/mocha/issues/4857">#4857</a>: Drop AMD/RequireJS support (<a href="https://github.com/juergba"><strong><code>@​juergba</code></strong></a>)</p> </li> <li> <p><a href="https://redirect.github.com/mochajs/mocha/issues/4866">#4866</a>: Drop Growl notification support (<a href="https://github.com/juergba"><strong><code>@​juergba</code></strong></a>)</p> </li> <li> <p><a href="https://redirect.github.com/mochajs/mocha/issues/4863">#4863</a>: Rename executable <code>bin/mocha</code> to <code>bin/mocha.js</code> (<a href="https://github.com/juergba"><strong><code>@​juergba</code></strong></a>)</p> </li> <li> <p><a href="https://redirect.github.com/mochajs/mocha/issues/4865">#4865</a>: <code>--ignore</code> option in Windows: upgrade Minimatch (<a href="https://github.com/juergba"><strong><code>@​juergba</code></strong></a>)</p> </li> <li> <p><a href="https://redirect.github.com/mochajs/mocha/issues/4861">#4861</a>: Remove deprecated <code>Runner</code> signature (<a href="https://github.com/juergba"><strong><code>@​juergba</code></strong></a>)</p> </li> </ul> <h2>:nut_and_bolt: Other</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/mochajs/mocha/blob/master/CHANGELOG.md">mocha's changelog</a>.</em></p> <blockquote> <h1>10.2.0 / 2022-12-11</h1> <h2>:tada: Enhancements</h2> <ul> <li><a href="https://redirect.github.com/mochajs/mocha/issues/4945">#4945</a>: API: add possibility to decorate ESM name before import (<a href="https://github.com/j0tunn"><strong><code>@​j0tunn</code></strong></a>)</li> </ul> <h2>:bug: Fixes</h2> <ul> <li><a href="https://redirect.github.com/mochajs/mocha/issues/4946">#4946</a>: Browser: color of failed test icon (<a href="https://github.com/kleisauke"><strong><code>@​kleisauke</code></strong></a>)</li> </ul> <h2>:book: Documentation</h2> <ul> <li><a href="https://redirect.github.com/mochajs/mocha/issues/4944">#4944</a>: Remove duplicated header (<a href="https://github.com/PauloGoncalvesBH"><strong><code>@​PauloGoncalvesBH</code></strong></a>)</li> </ul> <h1>10.1.0 / 2022-10-16</h1> <h2>:tada: Enhancements</h2> <ul> <li><a href="https://redirect.github.com/mochajs/mocha/issues/4896">#4896</a>: Browser: add support for <code>prefers-color-scheme: dark</code> (<a href="https://github.com/greggman"><strong><code>@​greggman</code></strong></a>)</li> </ul> <h2>:nut_and_bolt: Other</h2> <ul> <li><a href="https://redirect.github.com/mochajs/mocha/issues/4912">#4912</a>: Browser: increase contrast for replay buttons (<a href="https://github.com/JoshuaKGoldberg"><strong><code>@​JoshuaKGoldberg</code></strong></a>)</li> <li><a href="https://redirect.github.com/mochajs/mocha/issues/4905">#4905</a>: Use standard <code>Promise.allSettled</code> instead of polyfill (<a href="https://github.com/outsideris"><strong><code>@​outsideris</code></strong></a>)</li> <li><a href="https://redirect.github.com/mochajs/mocha/issues/4899">#4899</a>: Upgrade official GitHub actions to latest (<a href="https://github.com/ddzz"><strong><code>@​ddzz</code></strong></a>)</li> <li><a href="https://redirect.github.com/mochajs/mocha/issues/4770">#4770</a>: Fix regex in function <code>clean</code>(<a href="https://github.com/yetingli"><strong><code>@​yetingli</code></strong></a>)</li> </ul> <h1>10.0.0 / 2022-05-01</h1> <h2>:boom: Breaking Changes</h2> <ul> <li> <p><a href="https://redirect.github.com/mochajs/mocha/issues/4845">#4845</a>: <strong>Drop Node.js v12.x support</strong> (<a href="https://github.com/juergba"><strong><code>@​juergba</code></strong></a>)</p> </li> <li> <p><a href="https://redirect.github.com/mochajs/mocha/issues/4848">#4848</a>: Drop Internet-Explorer-11 support (<a href="https://github.com/juergba"><strong><code>@​juergba</code></strong></a>)</p> </li> <li> <p><a href="https://redirect.github.com/mochajs/mocha/issues/4857">#4857</a>: Drop AMD/RequireJS support (<a href="https://github.com/juergba"><strong><code>@​juergba</code></strong></a>)</p> </li> <li> <p><a href="https://redirect.github.com/mochajs/mocha/issues/4866">#4866</a>: Drop Growl notification support (<a href="https://github.com/juergba"><strong><code>@​juergba</code></strong></a>)</p> </li> <li> <p><a href="https://redirect.github.com/mochajs/mocha/issues/4863">#4863</a>: Rename executable <code>bin/mocha</code> to <code>bin/mocha.js</code> (<a href="https://github.com/juergba"><strong><code>@​juergba</code></strong></a>)</p> </li> <li> <p><a href="https://redirect.github.com/mochajs/mocha/issues/4865">#4865</a>: <code>--ignore</code> option in Windows: upgrade Minimatch (<a href="https://github.com/juergba"><strong><code>@​juergba</code></strong></a>)</p> </li> <li> <p><a href="https://redirect.github.com/mochajs/mocha/issues/4861">#4861</a>: Remove deprecated <code>Runner</code> signature (<a href="https://github.com/juergba"><strong><code>@​juergba</code></strong></a>)</p> </li> </ul> <h2>:nut_and_bolt: Other</h2> <ul> <li> <p><a href="https://redirect.github.com/mochajs/mocha/issues/4878">#4878</a>: Update production dependencies (<a href="https://github.com/juergba"><strong><code>@​juergba</code></strong></a>)</p> </li> <li> <p><a href="https://redirect.github.com/mochajs/mocha/issues/4876">#4876</a>: Add Node.js v18 to CI test matrix (<a href="https://github.com/outsideris"><strong><code>@​outsideris</code></strong></a>)</p> </li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/mochajs/mocha/commit/202e9b8b4d1b6611c96d95d631c49d631d88c827"><code>202e9b8</code></a> build(v10.2.0): release</li> <li><a href="https://github.com/mochajs/mocha/commit/6782d6d0757a5e7b49b291bcae173316ec00c513"><code>6782d6d</code></a> build(v10.2.0): update CHANGELOG</li> <li><a href="https://github.com/mochajs/mocha/commit/73bb81904fa017fc474973ce9b1e8fc325709142"><code>73bb819</code></a> feat(esm): ability to decorate ESM module name before importing it (<a href="https://redirect.github.com/mochajs/mocha/issues/4945">#4945</a>)</li> <li><a href="https://github.com/mochajs/mocha/commit/fc4ac58f1fda1a178b26189398b65f66f6561716"><code>fc4ac58</code></a> chore(devDeps): remove unused depedencies (<a href="https://redirect.github.com/mochajs/mocha/issues/4949">#4949</a>)</li> <li><a href="https://github.com/mochajs/mocha/commit/0a10ddc1213c208ccc106acc9e8bf372a25f0dc4"><code>0a10ddc</code></a> docs: remove duplicated header (<a href="https://redirect.github.com/mochajs/mocha/issues/4944">#4944</a>)</li> <li><a href="https://github.com/mochajs/mocha/commit/b0a0fb808c6d771f198fca120527222f92edaa57"><code>b0a0fb8</code></a> fix(browser): failed test icon color (<a href="https://redirect.github.com/mochajs/mocha/issues/4946">#4946</a>)</li> <li><a href="https://github.com/mochajs/mocha/commit/3cc9cac7ee040fff1de10af79fb16e7586ea65e8"><code>3cc9cac</code></a> ci: update stale action (<a href="https://redirect.github.com/mochajs/mocha/issues/4931">#4931</a>)</li> <li><a href="https://github.com/mochajs/mocha/commit/8f3c37b6b77b6754cd9445204c536c1a0671450a"><code>8f3c37b</code></a> chore(ci): workaround for firefox error (<a href="https://redirect.github.com/mochajs/mocha/issues/4933">#4933</a>)</li> <li><a href="https://github.com/mochajs/mocha/commit/5f96d511dbf913f135b92198aab721a27f6b44fe"><code>5f96d51</code></a> build(v10.1.0): release</li> <li><a href="https://github.com/mochajs/mocha/commit/ed74f16878f6520411d9a391c5f184056be6da30"><code>ed74f16</code></a> build(v10.1.0): update CHANGELOG</li> <li>Additional commits viewable in <a href="https://github.com/mochajs/mocha/compare/v5.2.0...v10.2.0">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~juergba">juergba</a>, a new releaser for mocha since your current version.</p> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/sitegui/nodejs-websocket/network/alerts). </details>
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin dependabot/npm_and_yarn/minimatch-and-mocha-5.0.1:dependabot/npm_and_yarn/minimatch-and-mocha-5.0.1
git switch dependabot/npm_and_yarn/minimatch-and-mocha-5.0.1

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff dependabot/npm_and_yarn/minimatch-and-mocha-5.0.1
git switch dependabot/npm_and_yarn/minimatch-and-mocha-5.0.1
git rebase master
git switch master
git merge --ff-only dependabot/npm_and_yarn/minimatch-and-mocha-5.0.1
git switch dependabot/npm_and_yarn/minimatch-and-mocha-5.0.1
git rebase master
git switch master
git merge --no-ff dependabot/npm_and_yarn/minimatch-and-mocha-5.0.1
git switch master
git merge --squash dependabot/npm_and_yarn/minimatch-and-mocha-5.0.1
git switch master
git merge --ff-only dependabot/npm_and_yarn/minimatch-and-mocha-5.0.1
git switch master
git merge dependabot/npm_and_yarn/minimatch-and-mocha-5.0.1
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: sitegui/nodejs-websocket#65
No description provided.
Delete branch "dependabot/npm_and_yarn/minimatch-and-mocha-5.0.1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?