sitegui/feattle-rs
1
0
Fork 0
Code Issues 7 Pull requests 2 Projects Releases 2 Packages Wiki Activity Actions

Add support for IndexMap and IndexSet in FeattleValue implementation #12

Open
santunioni wants to merge 2 commits from santunioni/master into master
pull from: santunioni/master
merge into: sitegui:master
Conversation 0 Commits 2 Files changed 3 +141 -58
santunioni commented 2025-05-14 10:26:58 +00:00 (Migrated from github.com)
Copy link

Add support for IndexMap and IndexSet in FeattleValue implementation

Description

We need support of IndexMap and IndexSet at iFood so we can parse toggles as these data structures.

I'm new to Rust and I am feeling that I may be overusing macros. Please let me know if that is the case, with a suggestion of how to avoid duplication in implementations of BTreeMap with IndexMap, or BTreeSet with IndexSet, if we should avoid at all.

Checklist

  • I have read
    CONTRIBUTING
    guidelines.
  • I have formatted the code using rustfmt
  • I have checked that all tests pass, by running cargo test --all

CHANGELOG:

  • Updated
  • I will update it after this PR has been discussed
  • No need to update
Add support for IndexMap and IndexSet in FeattleValue implementation ## Description We need support of IndexMap and IndexSet at iFood so we can parse toggles as these data structures. I'm new to Rust and I am feeling that I may be overusing macros. Please let me know if that is the case, with a suggestion of how to avoid duplication in implementations of BTreeMap with IndexMap, or BTreeSet with IndexSet, if we should avoid at all. ## Checklist - [x] I have read [CONTRIBUTING](https://github.com/sitegui/feattle-rs/blob/master/docs/CONTRIBUTING.md) guidelines. - [ ] I have formatted the code using [rustfmt](https://github.com/rust-lang/rustfmt) - [ ] I have checked that all tests pass, by running `cargo test --all` #### [CHANGELOG](https://github.com/sitegui/feattle-rs/blob/master/CHANGELOG.md): - [ ] Updated - [x] I will update it after this PR has been discussed - [ ] No need to update
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin santunioni/master:santunioni/master
git switch santunioni/master

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff santunioni/master
git switch santunioni/master
git rebase master
git switch master
git merge --ff-only santunioni/master
git switch santunioni/master
git rebase master
git switch master
git merge --no-ff santunioni/master
git switch master
git merge --squash santunioni/master
git switch master
git merge --ff-only santunioni/master
git switch master
git merge santunioni/master
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: sitegui/feattle-rs#12
No description provided.
Delete branch "santunioni/master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?